logpile no longer carries its own archive/vendor parsers or Redfish raw-payload replay/analysis engine. Both now live in git.mchus.pro/reanimator/parser/v13 (already used by the sibling `core` project), reached through parser.NewService().AnalyzeArchivePayload / AnalyzeRedfishRawPayloads. logpile keeps live BMC/Redfish collection, the DB, exporter, server and UI. - Deleted internal/parser/ (interface, registry, archive extraction, all vendor packages), internal/collector/redfish_replay*.go (replay engine, confirmed near-identical to the module's redfish/ package), internal/ingest/ (pure duplicate of the module's Service), internal/models/ (repointed every import to the module's models package instead), and internal/rar5 (only used by the deleted archive extractor). Removed the now-unused third_party/pciids submodule. - internal/collector/redfish.go: Collect() now calls parser.NewService().AnalyzeRedfishRawPayloads(...) at the one place it used to call the local ReplayRedfishFromRawPayloads (an existing "unified tunnel" between live collection and raw import). A deadcode-driven pass then removed ~150 doc-to-model conversion helpers in redfish.go that duplicated the module's redfish/ package and were already unreachable before this change; kept the small generic dedup/scoring helpers the live crawler still calls. - internal/collector/redfishprofile/ stays whole: Collect() depends on it directly for acquisition-time tuning. Its analysis-only methods (ApplyAnalysisProfiles/PostAnalyze) are now dead but left in place rather than splitting the package's single Profile interface. - pciids moved with the module (now a public package there); logpile's live collector and exporter import it from there instead of keeping a local copy. - go.mod: new require on git.mchus.pro/reanimator/parser/v13 v13.0.0 (plain module dependency, not a submodule like reanimator/chart, since this module is independently versioned and shared with core). - bible-local docs rewritten for the new boundary; see ADL-080. See also the companion change in git.mchus.pro/reanimator/parser (tagged v13.0.0): new top-level exports (IsSupportedArchiveFilename/SupportedArchiveExtensions/ ParseInDefaultArchiveLocation/PrivacyScanEnabled) and pciids moved to a public package, both needed to complete this migration. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
54 lines
1.5 KiB
Markdown
54 lines
1.5 KiB
Markdown
# 09 — Testing
|
|
|
|
## Baseline
|
|
|
|
Required before merge:
|
|
|
|
```bash
|
|
go test ./...
|
|
```
|
|
|
|
## Test locations
|
|
|
|
| Area | Location |
|
|
|------|----------|
|
|
| Live Redfish/BMC collection | `internal/collector/*_test.go` |
|
|
| HTTP handlers and jobs | `internal/server/*_test.go` |
|
|
| Exporters | `internal/exporter/*_test.go` |
|
|
| Vendor parsers and Redfish replay/analysis | external module `git.mchus.pro/reanimator/parser` — `internal/parser/vendors/<vendor>/*_test.go` and `redfish/*_test.go` there, not in this repo |
|
|
|
|
## General rules
|
|
|
|
- Prefer table-driven tests
|
|
- No network access in unit tests
|
|
- Cover happy path and realistic failure/partial-data cases
|
|
- New vendor parsers need both detection and parse coverage
|
|
|
|
## Mandatory coverage for dedup/filter/classify logic
|
|
|
|
Any new deduplication, filtering, or classification function must have:
|
|
|
|
1. A true-positive case
|
|
2. A true-negative case
|
|
3. A regression case for the vendor or topology that motivated the change
|
|
|
|
This is mandatory for inventory logic, firmware filtering, and similar code paths where silent data drift is likely.
|
|
|
|
## Mandatory coverage for expensive path selection
|
|
|
|
Any function that decides whether to crawl or probe an expensive path must have:
|
|
|
|
1. A positive selection case
|
|
2. A negative exclusion case
|
|
3. A topology-level count/integration case
|
|
|
|
The goal is to catch runaway I/O regressions before they ship.
|
|
|
|
## Useful focused commands
|
|
|
|
```bash
|
|
go test ./internal/exporter/...
|
|
go test ./internal/collector/...
|
|
go test ./internal/server/...
|
|
```
|