5 Commits
v1.2 ... v2.4

Author SHA1 Message Date
Mikhail Chusavitin
b38c878724 fix(viewer): set min-width on th cell to prevent column header truncation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-19 14:46:30 +03:00
Mikhail Chusavitin
969e246b81 fix(viewer): prevent column header placeholder truncation via min-width
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-19 14:45:19 +03:00
Mikhail Chusavitin
c94ae04fea feat(viewer): merge filter row into table header using placeholder text
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-19 14:41:31 +03:00
Mikhail Chusavitin
8105c7ec08 feat(viewer): replace severity dropdown with per-column header filters
Removes the standalone toolbar severity <select> and instead builds a
second <thead> row in JS with a text input (debounced 300 ms) per
column and a <select> for icon-only columns (severity_icon, status).
All active column filters apply together (AND logic). Adds data-col
attributes to <th> elements so JS can identify columns by name.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-21 14:26:30 +03:00
Mikhail Chusavitin
2a15bc87f1 feat(viewer): support hardware contract 2.10 2026-04-30 15:49:52 +03:00
7 changed files with 245 additions and 112 deletions

View File

@@ -10,7 +10,8 @@ It is designed to be embedded as a module in other Go applications that already
- Render one Reanimator JSON snapshot as HTML - Render one Reanimator JSON snapshot as HTML
- Read-only presentation of top-level metadata and hardware sections - Read-only presentation of top-level metadata and hardware sections
- Tabular rendering for arrays such as `cpus`, `memory`, `storage`, `pcie_devices`, `power_supplies`, and sensor subsections - Tabular rendering for arrays such as `cpus`, `memory`, `storage`, `pcie_devices`, `power_supplies`, `event_logs`, and sensor subsections
- Object rendering for singleton/config sections such as `board` and `platform_config`
- Status color coding for fast scanning - Status color coding for fast scanning
- Lightweight section navigation - Lightweight section navigation
- Standalone HTML rendering or embeddable HTTP handler - Standalone HTML rendering or embeddable HTTP handler

View File

@@ -30,13 +30,16 @@ Preferred order:
6. `pcie_devices` 6. `pcie_devices`
7. `power_supplies` 7. `power_supplies`
8. `sensors` 8. `sensors`
9. unknown sections 9. `event_logs`
10. `platform_config`
11. unknown sections
## Section Presentation ## Section Presentation
- singleton object sections render as key-value table - singleton object sections render as key-value table
- array sections render as compact data tables - array sections render as compact data tables
- sensors render as separate subtables for `fans`, `power`, `temperatures`, and `other` - sensors render as separate subtables for `fans`, `power`, `temperatures`, and `other`
- `platform_config` renders as a key-value table without interpreting setting names or values
## Visual Rules ## Visual Rules

View File

@@ -19,6 +19,8 @@ var sectionOrder = []string{
"pcie_devices", "pcie_devices",
"power_supplies", "power_supplies",
"sensors", "sensors",
"event_logs",
"platform_config",
} }
var sectionTitles = map[string]string{ var sectionTitles = map[string]string{
@@ -30,6 +32,8 @@ var sectionTitles = map[string]string{
"pcie_devices": "PCIe Devices", "pcie_devices": "PCIe Devices",
"power_supplies": "Power Supplies", "power_supplies": "Power Supplies",
"sensors": "Sensors", "sensors": "Sensors",
"event_logs": "Event Logs",
"platform_config": "Platform Config",
"fans": "Fans", "fans": "Fans",
"power": "Power", "power": "Power",
"temperatures": "Temperatures", "temperatures": "Temperatures",
@@ -73,9 +77,10 @@ var preferredColumns = map[string][]string{
"firmware": {"device_name", "version"}, "firmware": {"device_name", "version"},
"cpus": {"model", "clock", "cores", "threads", "l1", "l2", "l3", "microcode", "socket"}, "cpus": {"model", "clock", "cores", "threads", "l1", "l2", "l3", "microcode", "socket"},
"memory": {"part_number", "serial_number", "slot"}, "memory": {"part_number", "serial_number", "slot"},
"storage": {"type", "model", "serial_number", "firmware", "size_gb", "slot"}, "storage": {"type", "model", "serial_number", "firmware", "size_gb", "logical_block_size_bytes", "physical_block_size_bytes", "metadata_bytes_per_block", "slot"},
"pcie_devices": {"device_class", "manufacturer", "model", "serial_number", "mac_addresses", "slot", "numa_node", "link_speed", "link_width", "bdf"}, "pcie_devices": {"device_class", "manufacturer", "model", "serial_number", "mac_addresses", "slot", "numa_node", "link_speed", "link_width", "bdf"},
"power_supplies": {"vendor", "model", "part_number", "serial_number", "slot"}, "power_supplies": {"vendor", "model", "part_number", "serial_number", "slot"},
"event_logs": {"severity_icon", "source", "event_time", "severity", "message_id", "message", "component_ref", "fingerprint", "is_active", "raw_payload"},
"fans": {"name", "rpm"}, "fans": {"name", "rpm"},
"power": {"name", "voltage_v", "current_a", "power_w"}, "power": {"name", "voltage_v", "current_a", "power_w"},
"temperatures": {"name", "celsius", "threshold_warning_celsius", "threshold_critical_celsius"}, "temperatures": {"name", "celsius", "threshold_warning_celsius", "threshold_critical_celsius"},

View File

@@ -48,7 +48,7 @@ func TestRenderHTMLIncludesKnownSectionsAndFields(t *testing.T) {
} }
} }
for _, needle := range []string{ for _, needle := range []string{
`<th class="status-column" aria-label="status"></th>`, `<th data-col="status" class="status-column" aria-label="status"></th>`,
`<td class="status-column">`, `<td class="status-column">`,
`<span class="status-badge status-ok" role="img" aria-label="OK" title="OK"></span>`, `<span class="status-badge status-ok" role="img" aria-label="OK" title="OK"></span>`,
} { } {
@@ -278,7 +278,7 @@ func TestRenderHTMLGroupsPCIeDevicesByClass(t *testing.T) {
if strings.Contains(text, "<th>device_class</th>") { if strings.Contains(text, "<th>device_class</th>") {
t.Fatalf("expected device_class column to be hidden from PCIe tables") t.Fatalf("expected device_class column to be hidden from PCIe tables")
} }
if !strings.Contains(text, `<th class="status-column" aria-label="status"></th>`) { if !strings.Contains(text, `<th data-col="status" class="status-column" aria-label="status"></th>`) {
t.Fatalf("expected grouped PCIe tables to render compact status header cells") t.Fatalf("expected grouped PCIe tables to render compact status header cells")
} }
if !strings.Contains(text, `<span class="status-badge status-warning" role="img" aria-label="Warning" title="Warning"></span>`) { if !strings.Contains(text, `<span class="status-badge status-warning" role="img" aria-label="Warning" title="Warning"></span>`) {
@@ -320,15 +320,12 @@ func TestRenderHTMLAddsSeverityFilterForEventLogs(t *testing.T) {
text := string(html) text := string(html)
for _, needle := range []string{ for _, needle := range []string{
"Event Logs", "Event Logs",
"All severities",
`<option value="critical">Critical</option>`,
`<option value="info">Info</option>`,
`data-severity="critical"`, `data-severity="critical"`,
`data-severity="info"`, `data-severity="info"`,
`<th class="status-column" aria-label="severity"></th>`, `<th data-col="severity_icon" class="status-column" aria-label="severity"></th>`,
`<span class="status-badge severity-info" role="img" aria-label="Info" title="Info"></span>`, `<span class="status-badge severity-info" role="img" aria-label="Info" title="Info"></span>`,
`<span class="status-badge severity-critical" role="img" aria-label="Critical" title="Critical"></span>`, `<span class="status-badge severity-critical" role="img" aria-label="Critical" title="Critical"></span>`,
`<th>severity</th>`, `<th data-col="severity">severity</th>`,
"/static/view.js", "/static/view.js",
} { } {
if !strings.Contains(text, needle) { if !strings.Contains(text, needle) {
@@ -339,3 +336,81 @@ func TestRenderHTMLAddsSeverityFilterForEventLogs(t *testing.T) {
t.Fatalf("expected synthetic severity icon column header to remain visually empty") t.Fatalf("expected synthetic severity icon column header to remain visually empty")
} }
} }
func TestRenderHTMLDisplaysHardwareContract210Fields(t *testing.T) {
snapshot := []byte(`{
"filename": "redfish://10.10.10.103",
"source_type": "api",
"protocol": "redfish",
"target_host": "10.10.10.103",
"collected_at": "2026-02-10T15:30:00Z",
"hardware": {
"board": {
"manufacturer": "Supermicro",
"product_name": "X12DPG-QT6",
"serial_number": "21D634101"
},
"storage": [
{
"slot": "OB01",
"type": "NVMe",
"model": "INTEL SSDPF2KX076T1",
"size_gb": 7680,
"logical_block_size_bytes": 512,
"physical_block_size_bytes": 4096,
"metadata_bytes_per_block": 8,
"serial_number": "BTAX41900GF87P6DGN",
"manufacturer": "Intel",
"firmware": "9CV10510",
"interface": "NVMe",
"present": true,
"status": "OK"
}
],
"event_logs": [
{
"source": "redfish",
"event_time": "2026-03-15T14:03:20Z",
"severity": "Info",
"message_id": "OpenBMC.0.1.SystemReboot",
"message": "System reboot requested by administrator",
"component_ref": "Mainboard"
}
],
"platform_config": {
"SecureBoot": "Enabled",
"BiosVersion": "06.08.05",
"TpmEnabled": true,
"NumaEnabled": false,
"HyperThreading": "Enabled"
}
}
}`)
html, err := RenderHTML(snapshot, "Reanimator Chart")
if err != nil {
t.Fatalf("RenderHTML() error = %v", err)
}
text := string(html)
for _, needle := range []string{
"Storage",
"Event Logs",
"Platform Config",
`<th data-col="logical_block_size_bytes">logical_block_size_bytes</th>`,
`<th data-col="physical_block_size_bytes">physical_block_size_bytes</th>`,
`<th data-col="metadata_bytes_per_block">metadata_bytes_per_block</th>`,
"512",
"4096",
"8",
"SecureBoot",
"Enabled",
"TpmEnabled",
"true",
"System reboot requested by administrator",
} {
if !strings.Contains(text, needle) {
t.Fatalf("expected rendered html to contain %q", needle)
}
}
}

View File

@@ -289,6 +289,10 @@ body {
border-top: 0; border-top: 0;
} }
.data-table thead th:has(.col-filter) {
padding: 6px 10px;
}
.kv-table th { .kv-table th {
width: 1%; width: 1%;
} }
@@ -330,41 +334,57 @@ body {
display: block; display: block;
} }
.table-toolbar {
display: flex;
align-items: center;
gap: 10px;
margin: 0 0 10px;
}
.table-toolbar-label {
color: var(--muted);
font-size: 12px;
font-weight: 700;
letter-spacing: 0.04em;
text-transform: uppercase;
}
.table-severity-filter {
min-width: 180px;
border: 1px solid var(--border);
border-radius: 4px;
padding: 7px 10px;
background: var(--surface);
color: var(--ink);
font: inherit;
}
.table-severity-filter:focus-visible {
outline: 2px solid var(--accent);
outline-offset: 2px;
}
.table-filter-empty { .table-filter-empty {
margin: 10px 0 0; margin: 10px 0 0;
color: var(--muted); color: var(--muted);
} }
.col-filter-text {
width: 100%;
min-width: 40px;
border: 1px solid transparent;
border-radius: 3px;
padding: 2px 4px;
font: inherit;
font-size: inherit;
font-weight: 700;
background: transparent;
color: var(--ink);
}
.col-filter-text::placeholder {
color: var(--ink);
opacity: 1;
font-weight: 700;
}
.col-filter-text:focus-visible,
.col-filter-text:hover {
border-color: var(--border);
background: var(--surface);
font-weight: 400;
outline: 2px solid var(--accent);
outline-offset: 1px;
}
.col-filter-text:not(:placeholder-shown) {
border-color: var(--border);
background: var(--surface);
font-weight: 400;
}
.col-filter-select {
width: 100%;
min-width: 40px;
border: 1px solid var(--border);
border-radius: 3px;
padding: 3px 4px;
font: inherit;
font-size: 12px;
background: var(--surface);
color: var(--ink);
}
.data-table .status-column { .data-table .status-column {
width: 1%; width: 1%;
white-space: nowrap; white-space: nowrap;
@@ -425,13 +445,5 @@ body {
grid-column: auto; grid-column: auto;
} }
.table-toolbar {
align-items: stretch;
flex-direction: column;
}
.table-severity-filter {
min-width: 0;
width: 100%;
}
} }

View File

@@ -1,31 +1,94 @@
document.addEventListener("DOMContentLoaded", () => { document.addEventListener("DOMContentLoaded", () => {
document.querySelectorAll(".table-filterable").forEach((container) => { document.querySelectorAll(".table-filterable").forEach((container) => {
const select = container.querySelector(".table-severity-filter"); const table = container.querySelector(".data-table");
if (!select) { if (!table) return;
return;
const thead = table.querySelector("thead");
const headerRow = thead.querySelector("tr");
const headerCells = Array.from(headerRow.querySelectorAll("th"));
const emptyNotice = container.querySelector(".table-filter-empty");
const rows = Array.from(table.querySelectorAll("tbody tr"));
const activeFilters = new Map();
function getCellValue(cell, colName) {
if (colName === "severity_icon" || colName === "status") {
return (cell.querySelector(".status-badge")?.title || "").toLowerCase();
}
return cell.textContent.trim().toLowerCase();
} }
const rows = Array.from(container.querySelectorAll("tbody tr[data-severity-row='true']")); function applyFilters() {
const emptyNotice = container.querySelector(".table-filter-empty");
const applyFilter = () => {
const selected = select.value;
let visibleCount = 0; let visibleCount = 0;
rows.forEach((row) => { rows.forEach((row) => {
const matches = selected === "" || row.dataset.severity === selected; const cells = row.querySelectorAll("td");
row.hidden = !matches; let visible = true;
if (matches) { activeFilters.forEach((filterValue, colIndex) => {
visibleCount += 1; if (!filterValue) return;
const cell = cells[colIndex];
if (!cell) { visible = false; return; }
const colName = headerCells[colIndex]?.dataset.col || "";
if (!getCellValue(cell, colName).includes(filterValue)) visible = false;
});
row.hidden = !visible;
if (visible) visibleCount++;
});
if (emptyNotice) emptyNotice.hidden = visibleCount > 0;
}
headerCells.forEach((th, colIndex) => {
const colName = th.dataset.col || "";
const isIconCol = colName === "severity_icon" || colName === "status";
if (isIconCol) {
const select = document.createElement("select");
select.className = "col-filter col-filter-select";
select.setAttribute("aria-label", "filter " + (th.getAttribute("aria-label") || colName));
const allOpt = document.createElement("option");
allOpt.value = "";
allOpt.textContent = "All";
select.appendChild(allOpt);
const seen = new Set();
rows.forEach((row) => {
const cell = row.querySelectorAll("td")[colIndex];
if (!cell) return;
const val = cell.querySelector(".status-badge")?.title || "";
if (val && !seen.has(val)) {
seen.add(val);
const opt = document.createElement("option");
opt.value = val.toLowerCase();
opt.textContent = val;
select.appendChild(opt);
} }
}); });
if (emptyNotice) { if (select.options.length > 1) {
emptyNotice.hidden = visibleCount !== 0; select.addEventListener("change", () => {
activeFilters.set(colIndex, select.value);
applyFilters();
});
th.textContent = "";
th.appendChild(select);
} }
}; } else if (colName) {
const input = document.createElement("input");
select.addEventListener("change", applyFilter); input.type = "text";
applyFilter(); input.className = "col-filter col-filter-text";
input.placeholder = colName;
th.style.minWidth = `calc(${colName.length}ch + 20px)`;
input.setAttribute("aria-label", "filter " + colName);
let debounceTimer;
input.addEventListener("input", () => {
clearTimeout(debounceTimer);
debounceTimer = setTimeout(() => {
activeFilters.set(colIndex, input.value.trim().toLowerCase());
applyFilters();
}, 300);
});
th.textContent = "";
th.appendChild(input);
}
});
}); });
}); });

View File

@@ -64,24 +64,13 @@
{{ if eq .Kind "table" }} {{ if eq .Kind "table" }}
{{ $section := . }} {{ $section := . }}
<div class="table-block {{ if .SeverityOptions }}table-filterable{{ end }}"> <div class="table-block table-filterable">
{{ if .SeverityOptions }}
<div class="table-toolbar">
<label class="table-toolbar-label" for="{{ .ID }}-severity-filter">Severity</label>
<select class="table-severity-filter" id="{{ .ID }}-severity-filter">
<option value="">All severities</option>
{{ range .SeverityOptions }}
<option value="{{ .Value }}">{{ .Label }}</option>
{{ end }}
</select>
</div>
{{ end }}
<div class="table-wrap"> <div class="table-wrap">
<table class="data-table"> <table class="data-table">
<thead> <thead>
<tr> <tr>
{{ range .Columns }} {{ range .Columns }}
<th{{ if or (eq . "status") (eq . "severity_icon") }} class="status-column"{{ end }}{{ if eq . "status" }} aria-label="status"{{ end }}{{ if eq . "severity_icon" }} aria-label="severity"{{ end }}>{{ if and (ne . "status") (ne . "severity_icon") }}{{ . }}{{ end }}</th> <th data-col="{{ . }}"{{ if or (eq . "status") (eq . "severity_icon") }} class="status-column"{{ end }}{{ if eq . "status" }} aria-label="status"{{ end }}{{ if eq . "severity_icon" }} aria-label="severity"{{ end }}>{{ if and (ne . "status") (ne . "severity_icon") }}{{ . }}{{ end }}</th>
{{ end }} {{ end }}
</tr> </tr>
</thead> </thead>
@@ -108,9 +97,7 @@
</tbody> </tbody>
</table> </table>
</div> </div>
{{ if .SeverityOptions }} <p class="table-filter-empty" hidden>No rows match the active filters.</p>
<p class="table-filter-empty" hidden>No rows match the selected severity.</p>
{{ end }}
</div> </div>
{{ end }} {{ end }}
@@ -119,24 +106,13 @@
<div class="table-group"> <div class="table-group">
<h3>{{ .Title }}</h3> <h3>{{ .Title }}</h3>
{{ $group := . }} {{ $group := . }}
<div class="table-block {{ if .SeverityOptions }}table-filterable{{ end }}"> <div class="table-block table-filterable">
{{ if .SeverityOptions }}
<div class="table-toolbar">
<label class="table-toolbar-label">Severity</label>
<select class="table-severity-filter">
<option value="">All severities</option>
{{ range .SeverityOptions }}
<option value="{{ .Value }}">{{ .Label }}</option>
{{ end }}
</select>
</div>
{{ end }}
<div class="table-wrap"> <div class="table-wrap">
<table class="data-table"> <table class="data-table">
<thead> <thead>
<tr> <tr>
{{ range .Columns }} {{ range .Columns }}
<th{{ if or (eq . "status") (eq . "severity_icon") }} class="status-column"{{ end }}{{ if eq . "status" }} aria-label="status"{{ end }}{{ if eq . "severity_icon" }} aria-label="severity"{{ end }}>{{ if and (ne . "status") (ne . "severity_icon") }}{{ . }}{{ end }}</th> <th data-col="{{ . }}"{{ if or (eq . "status") (eq . "severity_icon") }} class="status-column"{{ end }}{{ if eq . "status" }} aria-label="status"{{ end }}{{ if eq . "severity_icon" }} aria-label="severity"{{ end }}>{{ if and (ne . "status") (ne . "severity_icon") }}{{ . }}{{ end }}</th>
{{ end }} {{ end }}
</tr> </tr>
</thead> </thead>
@@ -163,9 +139,7 @@
</tbody> </tbody>
</table> </table>
</div> </div>
{{ if .SeverityOptions }} <p class="table-filter-empty" hidden>No rows match the active filters.</p>
<p class="table-filter-empty" hidden>No rows match the selected severity.</p>
{{ end }}
</div> </div>
</div> </div>
{{ end }} {{ end }}