bee/audit/internal/app/sat_overlay_test.go

package app

import (
	"os"
	"path/filepath"
	"strings"
	"testing"

	"bee/audit/internal/collector"
	"bee/audit/internal/schema"
)

func TestApplyLatestSATStatusesMarksStorageByDevice(t *testing.T) {
	baseDir := t.TempDir()
	runDir := filepath.Join(baseDir, "storage-20260325-161151")
	if err := os.MkdirAll(runDir, 0755); err != nil {
		t.Fatal(err)
	}
	raw := "run_at_utc=2026-03-25T16:11:51Z\nnvme0n1_nvme_smart_log_status=OK\nsda_smartctl_health_status=FAILED\noverall_status=FAILED\n"
	if err := os.WriteFile(filepath.Join(runDir, "summary.txt"), []byte(raw), 0644); err != nil {
		t.Fatal(err)
	}

	nvme := schema.HardwareStorage{Telemetry: map[string]any{"linux_device": "/dev/nvme0n1"}}
	usb := schema.HardwareStorage{Telemetry: map[string]any{"linux_device": "/dev/sda"}}
	snap := schema.HardwareSnapshot{Storage: []schema.HardwareStorage{nvme, usb}}

	applyLatestSATStatuses(&snap, baseDir, nil)

	if snap.Storage[0].Status == nil || *snap.Storage[0].Status != "OK" {
		t.Fatalf("nvme status=%v want OK", snap.Storage[0].Status)
	}
	if snap.Storage[1].Status == nil || *snap.Storage[1].Status != "Critical" {
		t.Fatalf("sda status=%v want Critical", snap.Storage[1].Status)
	}
}

func TestApplyLatestSATStatusesMarksAMDGPUs(t *testing.T) {
	baseDir := t.TempDir()
	runDir := filepath.Join(baseDir, "gpu-amd-20260325-161436")
	if err := os.MkdirAll(runDir, 0755); err != nil {
		t.Fatal(err)
	}
	raw := "run_at_utc=2026-03-25T16:14:36Z\noverall_status=FAILED\n"
	if err := os.WriteFile(filepath.Join(runDir, "summary.txt"), []byte(raw), 0644); err != nil {
		t.Fatal(err)
	}

	class := "DisplayController"
	manufacturer := "Advanced Micro Devices, Inc. [AMD/ATI]"
	amdVendorID := collector.AMDVendorID
	snap := schema.HardwareSnapshot{
		PCIeDevices: []schema.HardwarePCIeDevice{{
			DeviceClass:  &class,
			Manufacturer: &manufacturer,
			VendorID:     &amdVendorID,
		}},
	}

	applyLatestSATStatuses(&snap, baseDir, nil)

	if snap.PCIeDevices[0].Status == nil || *snap.PCIeDevices[0].Status != "Critical" {
		t.Fatalf("gpu status=%v want Critical", snap.PCIeDevices[0].Status)
	}
}

// TestApplyLatestSATStatusesGPUFailureDescriptionNamesFailingSubJob guards
// against ErrorDescription regressing to a bare "amd GPU SAT failed" — an
// engineer reading the hardware snapshot (e.g. in a support bundle) needs to
// know which sub-job failed and its exit code, not just that something did.
func TestApplyLatestSATStatusesGPUFailureDescriptionNamesFailingSubJob(t *testing.T) {
	baseDir := t.TempDir()
	runDir := filepath.Join(baseDir, "gpu-amd-20260325-161436")
	if err := os.MkdirAll(runDir, 0755); err != nil {
		t.Fatal(err)
	}
	raw := "run_at_utc=2026-03-25T16:14:36Z\n" +
		"rocm-bandwidth-test_rc=1\n" +
		"rocm-bandwidth-test_status=FAILED\n" +
		"overall_status=FAILED\n"
	if err := os.WriteFile(filepath.Join(runDir, "summary.txt"), []byte(raw), 0644); err != nil {
		t.Fatal(err)
	}

	class := "DisplayController"
	amdVendorID := collector.AMDVendorID
	snap := schema.HardwareSnapshot{
		PCIeDevices: []schema.HardwarePCIeDevice{{DeviceClass: &class, VendorID: &amdVendorID}},
	}

	applyLatestSATStatuses(&snap, baseDir, nil)

	desc := snap.PCIeDevices[0].ErrorDescription
	if desc == nil || !strings.Contains(*desc, "rocm-bandwidth-test=FAILED (rc=1)") {
		t.Fatalf("ErrorDescription=%v, want it to name the failing sub-job and rc", desc)
	}
}

// TestApplyLatestSATStatusesStorageFailureDescriptionIncludesRC guards the
// per-device storage path, which must attribute the rc of *that device's*
// own failing job rather than any other device's.
func TestApplyLatestSATStatusesStorageFailureDescriptionIncludesRC(t *testing.T) {
	baseDir := t.TempDir()
	runDir := filepath.Join(baseDir, "storage-20260325-161151")
	if err := os.MkdirAll(runDir, 0755); err != nil {
		t.Fatal(err)
	}
	raw := "run_at_utc=2026-03-25T16:11:51Z\n" +
		"sda_smartctl_health_rc=2\n" +
		"sda_smartctl_health_status=FAILED\n" +
		"overall_status=FAILED\n"
	if err := os.WriteFile(filepath.Join(runDir, "summary.txt"), []byte(raw), 0644); err != nil {
		t.Fatal(err)
	}

	sda := schema.HardwareStorage{Telemetry: map[string]any{"linux_device": "/dev/sda"}}
	snap := schema.HardwareSnapshot{Storage: []schema.HardwareStorage{sda}}

	applyLatestSATStatuses(&snap, baseDir, nil)

	desc := snap.Storage[0].ErrorDescription
	if desc == nil || !strings.Contains(*desc, "rc=2") {
		t.Fatalf("ErrorDescription=%v, want it to include the failing job's rc", desc)
	}
}

func TestApplyLatestSATStatusesMarksNvidiaGPUByPerGPUStatusFile(t *testing.T) {
	baseDir := t.TempDir()
	runDir := filepath.Join(baseDir, "gpu-nvidia-20260407-162123")
	if err := os.MkdirAll(runDir, 0755); err != nil {
		t.Fatal(err)
	}
	if err := os.WriteFile(filepath.Join(runDir, "summary.txt"), []byte("run_at_utc=2026-04-07T16:21:23Z\noverall_status=FAILED\n"), 0644); err != nil {
		t.Fatal(err)
	}
	if err := os.WriteFile(filepath.Join(runDir, "gpu-1-status.txt"), []byte("gpu_index=1\ngpu_name=NVIDIA H100 PCIe\nrun_status=FAILED\nreason=GPU requires reset\n"), 0644); err != nil {
		t.Fatal(err)
	}

	class := "VideoController"
	manufacturer := "NVIDIA Corporation"
	bdf0 := "0000:4b:00.0"
	bdf1 := "0000:4f:00.0"
	snap := schema.HardwareSnapshot{
		PCIeDevices: []schema.HardwarePCIeDevice{
			{
				DeviceClass:  &class,
				Manufacturer: &manufacturer,
				BDF:          &bdf0,
				Telemetry:    map[string]any{"nvidia_gpu_index": 0},
			},
			{
				DeviceClass:  &class,
				Manufacturer: &manufacturer,
				BDF:          &bdf1,
				Telemetry:    map[string]any{"nvidia_gpu_index": 1},
			},
		},
	}

	applyLatestSATStatuses(&snap, baseDir, nil)

	if snap.PCIeDevices[1].Status == nil || *snap.PCIeDevices[1].Status != "Critical" {
		t.Fatalf("gpu1 status=%v want Critical", snap.PCIeDevices[1].Status)
	}
	if snap.PCIeDevices[1].ErrorDescription == nil || *snap.PCIeDevices[1].ErrorDescription != "GPU requires reset failed" {
		got := "<nil>"
		if snap.PCIeDevices[1].ErrorDescription != nil {
			got = *snap.PCIeDevices[1].ErrorDescription
		}
		t.Fatalf("gpu1 error=%q want per-gpu reason", got)
	}
}