reanimator/bee
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(pcie): stop misclassifying same-vendor non-GPU devices as GPUs

Browse Source 
matchesGPUVendor (sat_overlay.go) matched any PCIe DeviceClass containing
the substring "Controller" instead of the actual GPU classes, so a
same-vendor non-GPU device (e.g. an NVIDIA-branded NIC/storage controller)
with a degraded PCIe link surfaced as a pcie:gpu:<vendor> alarm on the
Hardware Summary/webui.

isGPUDevice (app_format.go) had the same bug via a different path: an
"any NVIDIA-vendor device is a GPU" fallback that could inflate the
"GPU: N x <model>" audit summary line with non-GPU companion devices
(NVSwitch/NVLink bridges, etc).

Both now defer to collector.IsGPUClass (exported from the previously
unexported isGPUClass), the canonical exact-match classifier already used
by amdgpu.go — removing the duplicated/incorrect class checks instead of
reimplementing them. Also dedup two more locally-duplicated classifiers
within webui (which doesn't import collector by convention): NIC-class
matching (pages.go/page_topo.go) and GPU-class matching in
page_validate.go now share one copy per package instead of being
reimplemented per file.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Mikhail Chusavitin
2026-08-17 12:50:50 +03:00
co-authored by Claude Sonnet 5
parent 4ac9863353
commit e3697c0a11
10 changed files with 92 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
audit/internal/app/app_format.go
+5 -8
View File
@@ -134,14 +134,11 @@ func isGPUDevice(dev schema.HardwarePCIeDevice) bool {
if dev.VendorID != nil && *dev.VendorID == collector.AspeedVendorID {
return false
}
class := trimPtr(dev.DeviceClass)
// AMD Instinct / Radeon compute GPUs always carry ProcessingAccelerator or DisplayController.
// Do NOT match AMD vendor alone — CPU chipset PCIe devices share that vendor ID.
if class == "VideoController" || class == "DisplayController" || class == "ProcessingAccelerator" {
return true
}
// NVIDIA devices sometimes expose class values outside the standard GPU set.
return dev.VendorID != nil && *dev.VendorID == collector.NvidiaVendorID
// AMD Instinct / Radeon and NVIDIA compute GPUs always carry VideoController,
// DisplayController, or ProcessingAccelerator. Do NOT match vendor ID alone —
// same-vendor companion devices (NVSwitch/NVLink bridges, CPU chipset PCIe
// functions, ...) share the GPU's vendor ID without being a GPU die.
return collector.IsGPUClass(trimPtr(dev.DeviceClass))
}
func formatSystemLine(board schema.HardwareBoard) string {