refactor: modularize audit and harden build validation

audit/internal/collector/nic_mellanox.go

@@ -30,7 +30,7 @@ var (
 		return string(out), nil
 	}
 
-	netIfacesByBDF = listNetIfacesByBDF
+	netIfacesByBDF     = listNetIfacesByBDF
 	readNetCarrierFile = func(iface string) (string, error) {
 		path := filepath.Join("/sys/class/net", iface, "carrier")
 		raw, err := os.ReadFile(path)

audit/internal/collector/sensors.go

@@ -3,7 +3,6 @@ package collector
 import (
 	"bee/audit/internal/schema"
 	"encoding/json"
-	"log/slog"
 	"os/exec"
 	"sort"
 	"strconv"
@@ -12,25 +11,6 @@ import (
 
 type sensorsDoc map[string]map[string]any
 
-func collectSensors() *schema.HardwareSensors {
-	doc, err := readSensorsJSONDoc()
-	if err != nil {
-		slog.Info("sensors: unavailable, skipping", "err", err)
-		return nil
-	}
-	sensors := buildSensorsFromDoc(doc)
-	if sensors == nil || (len(sensors.Fans) == 0 && len(sensors.Power) == 0 && len(sensors.Temperatures) == 0 && len(sensors.Other) == 0) {
-		return nil
-	}
-	slog.Info("sensors: collected",
-		"fans", len(sensors.Fans),
-		"power", len(sensors.Power),
-		"temperatures", len(sensors.Temperatures),
-		"other", len(sensors.Other),
-	)
-	return sensors
-}
-
 func readSensorsJSONDoc() (sensorsDoc, error) {
 	out, err := exec.Command("sensors", "-j").Output()
 	if err != nil {

audit/internal/collector/storage.go

@@ -280,9 +280,9 @@ type smartctlInfo struct {
 	ScsiVendor    string `json:"scsi_vendor"`
 	ScsiProduct   string `json:"scsi_product"`
 	SerialNumber  string `json:"serial_number"`
-	FirmwareVer  string `json:"firmware_version"`
-	RotationRate int    `json:"rotation_rate"`
-	Temperature  struct {
+	FirmwareVer   string `json:"firmware_version"`
+	RotationRate  int    `json:"rotation_rate"`
+	Temperature   struct {
 		Current int `json:"current"`
 	} `json:"temperature"`
 	SmartStatus struct {