From 7d64e5d215287811946bea7c843eb18bc39bc6ac Mon Sep 17 00:00:00 2001 From: Michael Chus Date: Sat, 18 Apr 2026 15:07:27 +0300 Subject: [PATCH] Fix two stale failing tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - TestHandleAPIBenchmarkPowerFitRampQueuesBenchmarkPowerFitTasks: ramp-up mode intentionally creates a single task (the runner handles 1→N internally to avoid redundant repetition of earlier ramp steps). Updated the test to expect 1 task and verify RampTotal=3 instead of asserting 3 separate tasks. - TestBenchmarkPageRendersSavedResultsTable: benchmark page used "Performance Results" as heading while the test looked for "Perf Results". Aligned the page heading with the shorter label used everywhere else (task reports, etc.). Co-Authored-By: Claude Sonnet 4.6 --- audit/internal/webui/api_test.go | 22 +++++++++++++--------- audit/internal/webui/pages.go | 2 +- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/audit/internal/webui/api_test.go b/audit/internal/webui/api_test.go index 3ac9f90..77f5826 100644 --- a/audit/internal/webui/api_test.go +++ b/audit/internal/webui/api_test.go @@ -178,16 +178,20 @@ func TestHandleAPIBenchmarkPowerFitRampQueuesBenchmarkPowerFitTasks(t *testing.T } globalQueue.mu.Lock() defer globalQueue.mu.Unlock() - if len(globalQueue.tasks) != 3 { - t.Fatalf("tasks=%d want 3", len(globalQueue.tasks)) + // Ramp-up mode creates a single task that handles the 1→N GPU ramp internally + // (spawning N separate tasks would redundantly repeat all earlier ramp steps). + if len(globalQueue.tasks) != 1 { + t.Fatalf("tasks=%d want 1 (ramp-up uses single task)", len(globalQueue.tasks)) } - for i, task := range globalQueue.tasks { - if task.Target != "nvidia-bench-power" { - t.Fatalf("task[%d] target=%q", i, task.Target) - } - if task.Priority != taskPriorityBenchmark { - t.Fatalf("task[%d] priority=%d want %d", i, task.Priority, taskPriorityBenchmark) - } + task := globalQueue.tasks[0] + if task.Target != "nvidia-bench-power" { + t.Fatalf("task target=%q want nvidia-bench-power", task.Target) + } + if task.Priority != taskPriorityBenchmark { + t.Fatalf("task priority=%d want %d", task.Priority, taskPriorityBenchmark) + } + if task.params.RampTotal != 3 { + t.Fatalf("task RampTotal=%d want 3", task.params.RampTotal) } } diff --git a/audit/internal/webui/pages.go b/audit/internal/webui/pages.go index 4aab57b..5ee6ac3 100644 --- a/audit/internal/webui/pages.go +++ b/audit/internal/webui/pages.go @@ -2385,7 +2385,7 @@ function benchmarkRefreshResults() { func renderBenchmarkResultsCard(exportDir string) string { maxIdx, runs := loadBenchmarkHistory(exportDir) perf := renderBenchmarkResultsCardFromRuns( - "Performance Results", + "Perf Results", "Composite score by saved benchmark run and GPU.", "No saved performance benchmark runs yet.", maxIdx,