refactor: harden diagnostics and consolidate runtime code

audit/internal/webui/page_topo.go

@@ -11,6 +11,7 @@ import (
 	"strconv"
 	"strings"
 
+	"bee/audit/internal/platform"
 	"bee/audit/internal/schema"
 )
 
@@ -246,17 +247,7 @@ func buildMemoryColumnIndex(rawNodes []int) map[int]int {
 // GPU pairwise NVLink adjacency (from a live "nvidia-smi topo -m" query)
 // ---------------------------------------------------------------------------
 
-type gpuPairLink struct {
-	GPUA, GPUB int
-	NVLinks    int
-}
-
-var topoNVRe = regexp.MustCompile(`(?i)^NV(\d+)$`)
-
-// nvidia-smi underlines the topo -m header row with ANSI CSI sequences
-// (ESC[4m...ESC[0m) even when stdout is not a TTY, so the captured techdump
-// contains them and "GPU0" is not at the start of the trimmed header line.
-var topoANSIRe = regexp.MustCompile("\x1b\\[[0-9;]*[A-Za-z]")
+type gpuPairLink = platform.NvidiaNVLinkBondedPair
 
 // parseGPUPairAdjacency returns every GPU pair with a nonzero NVLink bond
 // count from a "nvidia-smi topo -m" matrix. Unlike parseNVIDIATopologyMatrix
@@ -264,86 +255,7 @@ var topoANSIRe = regexp.MustCompile("\x1b\\[[0-9;]*[A-Za-z]")
 // who is bonded to whom — required so GPU-GPU edges are drawn for actually
 // bonded pairs, not for adjacent boxes in the layout.
 func parseGPUPairAdjacency(raw string) []gpuPairLink {
-	lines := strings.Split(topoANSIRe.ReplaceAllString(raw, ""), "\n")
-	headerIdx := -1
-	var gpuColIndices []int
-	for i, line := range lines {
-		trimmed := strings.TrimSpace(line)
-		if strings.HasPrefix(trimmed, "GPU0") {
-			parts := strings.Fields(trimmed)
-			for j, col := range parts {
-				if strings.HasPrefix(col, "GPU") {
-					gpuColIndices = append(gpuColIndices, j)
-				}
-			}
-			if len(gpuColIndices) >= 2 {
-				headerIdx = i
-			}
-			break
-		}
-	}
-	if headerIdx < 0 {
-		return nil
-	}
-
-	colIdxToGPU := make(map[int]int, len(gpuColIndices))
-	for gpuIdx, colIdx := range gpuColIndices {
-		colIdxToGPU[colIdx] = gpuIdx
-	}
-
-	seen := map[[2]int]bool{}
-	var pairs []gpuPairLink
-	rowGPU := -1
-	for _, line := range lines[headerIdx+1:] {
-		trimmed := strings.TrimSpace(line)
-		if !strings.HasPrefix(trimmed, "GPU") {
-			continue
-		}
-		cells := strings.Fields(trimmed)
-		if len(cells) == 0 {
-			continue
-		}
-		rowLabel := strings.TrimPrefix(cells[0], "GPU")
-		n, err := strconv.Atoi(rowLabel)
-		if err != nil {
-			continue
-		}
-		rowGPU = n
-		for colIdx, colGPU := range colIdxToGPU {
-			if colGPU == rowGPU {
-				continue
-			}
-			dataIdx := colIdx + 1
-			if dataIdx >= len(cells) {
-				continue
-			}
-			m := topoNVRe.FindStringSubmatch(cells[dataIdx])
-			if len(m) != 2 {
-				continue
-			}
-			nv, err := strconv.Atoi(m[1])
-			if err != nil || nv <= 0 {
-				continue
-			}
-			a, bGPU := rowGPU, colGPU
-			if a > bGPU {
-				a, bGPU = bGPU, a
-			}
-			key := [2]int{a, bGPU}
-			if seen[key] {
-				continue
-			}
-			seen[key] = true
-			pairs = append(pairs, gpuPairLink{GPUA: a, GPUB: bGPU, NVLinks: nv})
-		}
-	}
-	sort.Slice(pairs, func(i, j int) bool {
-		if pairs[i].GPUA != pairs[j].GPUA {
-			return pairs[i].GPUA < pairs[j].GPUA
-		}
-		return pairs[i].GPUB < pairs[j].GPUB
-	})
-	return pairs
+	return platform.ParseNvidiaNVLinkBondedPairs(raw)
 }
 
 // readTopoTechDump reads a file previously captured into the persistent