Files
logpile/internal/server/topology_view_test.go
T
Mikhail ChusavitinandClaude Sonnet 5 475318fc2b refactor: extract parsers and Redfish replay/analysis to external module
logpile no longer carries its own archive/vendor parsers or Redfish
raw-payload replay/analysis engine. Both now live in
git.mchus.pro/reanimator/parser/v13 (already used by the sibling `core`
project), reached through parser.NewService().AnalyzeArchivePayload /
AnalyzeRedfishRawPayloads. logpile keeps live BMC/Redfish collection,
the DB, exporter, server and UI.

- Deleted internal/parser/ (interface, registry, archive extraction,
  all vendor packages), internal/collector/redfish_replay*.go (replay
  engine, confirmed near-identical to the module's redfish/ package),
  internal/ingest/ (pure duplicate of the module's Service),
  internal/models/ (repointed every import to the module's models
  package instead), and internal/rar5 (only used by the deleted
  archive extractor). Removed the now-unused third_party/pciids
  submodule.
- internal/collector/redfish.go: Collect() now calls
  parser.NewService().AnalyzeRedfishRawPayloads(...) at the one place
  it used to call the local ReplayRedfishFromRawPayloads (an existing
  "unified tunnel" between live collection and raw import). A
  deadcode-driven pass then removed ~150 doc-to-model conversion
  helpers in redfish.go that duplicated the module's redfish/ package
  and were already unreachable before this change; kept the small
  generic dedup/scoring helpers the live crawler still calls.
- internal/collector/redfishprofile/ stays whole: Collect() depends on
  it directly for acquisition-time tuning. Its analysis-only methods
  (ApplyAnalysisProfiles/PostAnalyze) are now dead but left in place
  rather than splitting the package's single Profile interface.
- pciids moved with the module (now a public package there); logpile's
  live collector and exporter import it from there instead of keeping
  a local copy.
- go.mod: new require on git.mchus.pro/reanimator/parser/v13 v13.0.0
  (plain module dependency, not a submodule like reanimator/chart,
  since this module is independently versioned and shared with core).
- bible-local docs rewritten for the new boundary; see ADL-080.

See also the companion change in git.mchus.pro/reanimator/parser
(tagged v13.0.0): new top-level exports
(IsSupportedArchiveFilename/SupportedArchiveExtensions/
ParseInDefaultArchiveLocation/PrivacyScanEnabled) and pciids moved to
a public package, both needed to complete this migration.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-10-08 12:59:39 +03:00

72 lines
2.0 KiB
Go

package server
import (
"archive/zip"
"bytes"
"io"
"net/http"
"net/http/httptest"
"strings"
"testing"
"git.mchus.pro/reanimator/parser/v13/models"
)
func topologyTestResult() *models.AnalysisResult {
return &models.AnalysisResult{Filename: "bee.tar.gz", Hardware: &models.HardwareConfig{
BoardInfo: models.BoardInfo{ProductName: "SYS-TEST", SerialNumber: "SN123"},
CPUs: []models.CPU{{Socket: 0, Model: "Xeon", Status: "OK"}},
PCIeDevices: []models.PCIeDevice{{
Slot: "0000:31:00.0", BDF: "0000:31:00.0", DeviceClass: "VideoController",
Model: "NVIDIA GPU", NUMANode: intPtr(0), Status: "OK",
}},
}}
}
func TestTopologyEndpointsPreserveNUMAZero(t *testing.T) {
s := New(Config{})
s.SetResult(topologyTestResult())
for _, tc := range []struct{ path, want string }{{"/api/topology", `"numa_node": 0`}, {"/topology/current", "SYS-TEST - SN123"}} {
rec := httptest.NewRecorder()
s.mux.ServeHTTP(rec, httptest.NewRequest(http.MethodGet, tc.path, nil))
if rec.Code != http.StatusOK {
t.Fatalf("%s returned %d: %s", tc.path, rec.Code, rec.Body.String())
}
if !strings.Contains(rec.Body.String(), tc.want) {
t.Fatalf("%s missing %q: %s", tc.path, tc.want, rec.Body.String())
}
}
}
func TestRawExportBundleContainsSeparateTopologyJSON(t *testing.T) {
result := topologyTestResult()
pkg := newRawExportFromUploadedFile(result.Filename, "application/gzip", []byte("source"), result)
body, err := buildRawExportBundle(pkg, result, "test")
if err != nil {
t.Fatal(err)
}
zr, err := zip.NewReader(bytes.NewReader(body), int64(len(body)))
if err != nil {
t.Fatal(err)
}
for _, f := range zr.File {
if f.Name != rawExportBundleTopologyFile {
continue
}
r, err := f.Open()
if err != nil {
t.Fatal(err)
}
data, err := io.ReadAll(r)
_ = r.Close()
if err != nil {
t.Fatal(err)
}
if !strings.Contains(string(data), `"version": "1.0"`) {
t.Fatalf("unexpected topology.json: %s", data)
}
return
}
t.Fatal("raw export bundle has no topology.json")
}