Files
logpile/internal/server/privacy_scan_test.go
T
Mikhail ChusavitinandClaude Sonnet 5 475318fc2b refactor: extract parsers and Redfish replay/analysis to external module
logpile no longer carries its own archive/vendor parsers or Redfish
raw-payload replay/analysis engine. Both now live in
git.mchus.pro/reanimator/parser/v13 (already used by the sibling `core`
project), reached through parser.NewService().AnalyzeArchivePayload /
AnalyzeRedfishRawPayloads. logpile keeps live BMC/Redfish collection,
the DB, exporter, server and UI.

- Deleted internal/parser/ (interface, registry, archive extraction,
  all vendor packages), internal/collector/redfish_replay*.go (replay
  engine, confirmed near-identical to the module's redfish/ package),
  internal/ingest/ (pure duplicate of the module's Service),
  internal/models/ (repointed every import to the module's models
  package instead), and internal/rar5 (only used by the deleted
  archive extractor). Removed the now-unused third_party/pciids
  submodule.
- internal/collector/redfish.go: Collect() now calls
  parser.NewService().AnalyzeRedfishRawPayloads(...) at the one place
  it used to call the local ReplayRedfishFromRawPayloads (an existing
  "unified tunnel" between live collection and raw import). A
  deadcode-driven pass then removed ~150 doc-to-model conversion
  helpers in redfish.go that duplicated the module's redfish/ package
  and were already unreachable before this change; kept the small
  generic dedup/scoring helpers the live crawler still calls.
- internal/collector/redfishprofile/ stays whole: Collect() depends on
  it directly for acquisition-time tuning. Its analysis-only methods
  (ApplyAnalysisProfiles/PostAnalyze) are now dead but left in place
  rather than splitting the package's single Profile interface.
- pciids moved with the module (now a public package there); logpile's
  live collector and exporter import it from there instead of keeping
  a local copy.
- go.mod: new require on git.mchus.pro/reanimator/parser/v13 v13.0.0
  (plain module dependency, not a submodule like reanimator/chart,
  since this module is independently versioned and shared with core).
- bible-local docs rewritten for the new boundary; see ADL-080.

See also the companion change in git.mchus.pro/reanimator/parser
(tagged v13.0.0): new top-level exports
(IsSupportedArchiveFilename/SupportedArchiveExtensions/
ParseInDefaultArchiveLocation/PrivacyScanEnabled) and pciids moved to
a public package, both needed to complete this migration.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-10-08 12:59:39 +03:00

102 lines
2.7 KiB
Go

package server
import (
"archive/zip"
"bytes"
"encoding/json"
"net/http"
"net/http/httptest"
"testing"
"git.mchus.pro/reanimator/parser/v13/models"
)
func samplePrivacyScan() *models.PrivacyScan {
return &models.PrivacyScan{
FilesScanned: 3,
Customers: []models.CustomerGuess{{Domain: "acme.ru", Confidence: "high", Hits: 4}},
Findings: []models.PrivacyFinding{
{Category: "resolv", Severity: "high", Path: "resolv.conf", Line: 1, Match: "corp.acme.ru"},
},
Summary: models.PrivacySummary{Total: 1, High: 1, ByCategory: map[string]int{"resolv": 1}},
}
}
func TestHandleGetPrivacyScan_NotLoaded(t *testing.T) {
srv := &Server{}
req := httptest.NewRequest("GET", "/api/privacy-scan", nil)
w := httptest.NewRecorder()
srv.handleGetPrivacyScan(w, req)
if w.Code != http.StatusOK {
t.Fatalf("status = %d", w.Code)
}
var body map[string]any
if err := json.Unmarshal(w.Body.Bytes(), &body); err != nil {
t.Fatal(err)
}
if body["loaded"] != false {
t.Fatalf("want loaded:false, got %v", body)
}
}
func TestHandleGetPrivacyScan_Loaded(t *testing.T) {
srv := &Server{}
srv.SetResult(&models.AnalysisResult{PrivacyScan: samplePrivacyScan()})
req := httptest.NewRequest("GET", "/api/privacy-scan", nil)
w := httptest.NewRecorder()
srv.handleGetPrivacyScan(w, req)
if w.Code != http.StatusOK {
t.Fatalf("status = %d", w.Code)
}
var got models.PrivacyScan
if err := json.Unmarshal(w.Body.Bytes(), &got); err != nil {
t.Fatal(err)
}
if len(got.Customers) != 1 || got.Customers[0].Domain != "acme.ru" {
t.Fatalf("unexpected payload: %+v", got)
}
}
func TestBuildRawExportBundle_IncludesPrivacyReport(t *testing.T) {
pkg := newRawExportFromUploadedFile("dump.tar.gz", "application/gzip", []byte("x"), &models.AnalysisResult{})
result := &models.AnalysisResult{PrivacyScan: samplePrivacyScan()}
raw, err := buildRawExportBundle(pkg, result, "test")
if err != nil {
t.Fatal(err)
}
zr, err := zip.NewReader(bytes.NewReader(raw), int64(len(raw)))
if err != nil {
t.Fatal(err)
}
found := false
for _, f := range zr.File {
if f.Name == rawExportBundlePrivacyFile {
found = true
}
}
if !found {
t.Fatalf("%s missing from bundle", rawExportBundlePrivacyFile)
}
}
func TestBuildRawExportBundle_NoPrivacyReportWhenNil(t *testing.T) {
pkg := newRawExportFromUploadedFile("dump.tar.gz", "application/gzip", []byte("x"), &models.AnalysisResult{})
raw, err := buildRawExportBundle(pkg, &models.AnalysisResult{}, "test")
if err != nil {
t.Fatal(err)
}
zr, err := zip.NewReader(bytes.NewReader(raw), int64(len(raw)))
if err != nil {
t.Fatal(err)
}
for _, f := range zr.File {
if f.Name == rawExportBundlePrivacyFile {
t.Fatalf("%s should be absent when PrivacyScan is nil", rawExportBundlePrivacyFile)
}
}
}