logpile no longer carries its own archive/vendor parsers or Redfish raw-payload replay/analysis engine. Both now live in git.mchus.pro/reanimator/parser/v13 (already used by the sibling `core` project), reached through parser.NewService().AnalyzeArchivePayload / AnalyzeRedfishRawPayloads. logpile keeps live BMC/Redfish collection, the DB, exporter, server and UI. - Deleted internal/parser/ (interface, registry, archive extraction, all vendor packages), internal/collector/redfish_replay*.go (replay engine, confirmed near-identical to the module's redfish/ package), internal/ingest/ (pure duplicate of the module's Service), internal/models/ (repointed every import to the module's models package instead), and internal/rar5 (only used by the deleted archive extractor). Removed the now-unused third_party/pciids submodule. - internal/collector/redfish.go: Collect() now calls parser.NewService().AnalyzeRedfishRawPayloads(...) at the one place it used to call the local ReplayRedfishFromRawPayloads (an existing "unified tunnel" between live collection and raw import). A deadcode-driven pass then removed ~150 doc-to-model conversion helpers in redfish.go that duplicated the module's redfish/ package and were already unreachable before this change; kept the small generic dedup/scoring helpers the live crawler still calls. - internal/collector/redfishprofile/ stays whole: Collect() depends on it directly for acquisition-time tuning. Its analysis-only methods (ApplyAnalysisProfiles/PostAnalyze) are now dead but left in place rather than splitting the package's single Profile interface. - pciids moved with the module (now a public package there); logpile's live collector and exporter import it from there instead of keeping a local copy. - go.mod: new require on git.mchus.pro/reanimator/parser/v13 v13.0.0 (plain module dependency, not a submodule like reanimator/chart, since this module is independently versioned and shared with core). - bible-local docs rewritten for the new boundary; see ADL-080. See also the companion change in git.mchus.pro/reanimator/parser (tagged v13.0.0): new top-level exports (IsSupportedArchiveFilename/SupportedArchiveExtensions/ ParseInDefaultArchiveLocation/PrivacyScanEnabled) and pciids moved to a public package, both needed to complete this migration. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
84 lines
2.3 KiB
Go
84 lines
2.3 KiB
Go
package server
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"git.mchus.pro/reanimator/parser/v13/models"
|
|
)
|
|
|
|
func TestExtractFirmwareComponentAndModel_GPUUsesPartNumberFromParentheses(t *testing.T) {
|
|
component, model := extractFirmwareComponentAndModel("GPU GPUSXM3 (692-2G520-0280-501)")
|
|
if component != "GPU" {
|
|
t.Fatalf("expected component GPU, got %q", component)
|
|
}
|
|
if model != "692-2G520-0280-501" {
|
|
t.Fatalf("expected GPU model 692-2G520-0280-501, got %q", model)
|
|
}
|
|
}
|
|
|
|
func TestExtractFirmwareComponentAndModel_GPUFallbackWithoutParentheses(t *testing.T) {
|
|
component, model := extractFirmwareComponentAndModel("GPU 692-2G520-0280-501")
|
|
if component != "GPU" {
|
|
t.Fatalf("expected component GPU, got %q", component)
|
|
}
|
|
if model != "692-2G520-0280-501" {
|
|
t.Fatalf("expected GPU model 692-2G520-0280-501, got %q", model)
|
|
}
|
|
}
|
|
|
|
func TestBuildFirmwareEntries_IncludesGPUFirmwareFallback(t *testing.T) {
|
|
hw := &models.HardwareConfig{
|
|
Firmware: []models.FirmwareInfo{
|
|
{DeviceName: "BIOS", Version: "1.0.0"},
|
|
},
|
|
GPUs: []models.GPU{
|
|
{
|
|
Slot: "#CPU0_PCIE2",
|
|
Model: "GH100 [H200 NVL]",
|
|
PartNumber: "699-2G530-0200-501",
|
|
Firmware: "96.00.B7.00.02",
|
|
},
|
|
{
|
|
Slot: "#CPU0_PCIE1",
|
|
Model: "GH100 [H200 NVL]",
|
|
PartNumber: "699-2G530-0200-501",
|
|
Firmware: "96.00.B7.00.02",
|
|
},
|
|
},
|
|
}
|
|
|
|
entries := buildFirmwareEntries(hw)
|
|
if len(entries) != 2 {
|
|
t.Fatalf("expected 2 deduplicated firmware entries, got %d", len(entries))
|
|
}
|
|
|
|
var hasGPU bool
|
|
for _, e := range entries {
|
|
if e.Component == "GPU" && e.Version == "96.00.B7.00.02" {
|
|
hasGPU = true
|
|
}
|
|
}
|
|
if !hasGPU {
|
|
t.Fatalf("expected GPU firmware entry from hardware.gpus fallback")
|
|
}
|
|
}
|
|
|
|
func TestBuildFirmwareEntries_SkipsPlaceholderVersions(t *testing.T) {
|
|
hw := &models.HardwareConfig{
|
|
Firmware: []models.FirmwareInfo{
|
|
{DeviceName: "BMC", Version: "3.13.42P13"},
|
|
{DeviceName: "Front_BP_1", Version: "NA"},
|
|
{DeviceName: "Rear_BP_0", Version: "N/A"},
|
|
{DeviceName: "HDD_BP", Version: "-"},
|
|
},
|
|
}
|
|
|
|
entries := buildFirmwareEntries(hw)
|
|
if len(entries) != 1 {
|
|
t.Fatalf("expected only usable firmware entries, got %#v", entries)
|
|
}
|
|
if entries[0].Component != "BMC" || entries[0].Version != "3.13.42P13" {
|
|
t.Fatalf("unexpected remaining firmware entry: %#v", entries[0])
|
|
}
|
|
}
|