Files
logpile/internal/privacy/unit_test.go
T
Mikhail ChusavitinandClaude Sonnet 5 475318fc2b refactor: extract parsers and Redfish replay/analysis to external module
logpile no longer carries its own archive/vendor parsers or Redfish
raw-payload replay/analysis engine. Both now live in
git.mchus.pro/reanimator/parser/v13 (already used by the sibling `core`
project), reached through parser.NewService().AnalyzeArchivePayload /
AnalyzeRedfishRawPayloads. logpile keeps live BMC/Redfish collection,
the DB, exporter, server and UI.

- Deleted internal/parser/ (interface, registry, archive extraction,
  all vendor packages), internal/collector/redfish_replay*.go (replay
  engine, confirmed near-identical to the module's redfish/ package),
  internal/ingest/ (pure duplicate of the module's Service),
  internal/models/ (repointed every import to the module's models
  package instead), and internal/rar5 (only used by the deleted
  archive extractor). Removed the now-unused third_party/pciids
  submodule.
- internal/collector/redfish.go: Collect() now calls
  parser.NewService().AnalyzeRedfishRawPayloads(...) at the one place
  it used to call the local ReplayRedfishFromRawPayloads (an existing
  "unified tunnel" between live collection and raw import). A
  deadcode-driven pass then removed ~150 doc-to-model conversion
  helpers in redfish.go that duplicated the module's redfish/ package
  and were already unreachable before this change; kept the small
  generic dedup/scoring helpers the live crawler still calls.
- internal/collector/redfishprofile/ stays whole: Collect() depends on
  it directly for acquisition-time tuning. Its analysis-only methods
  (ApplyAnalysisProfiles/PostAnalyze) are now dead but left in place
  rather than splitting the package's single Profile interface.
- pciids moved with the module (now a public package there); logpile's
  live collector and exporter import it from there instead of keeping
  a local copy.
- go.mod: new require on git.mchus.pro/reanimator/parser/v13 v13.0.0
  (plain module dependency, not a submodule like reanimator/chart,
  since this module is independently versioned and shared with core).
- bible-local docs rewritten for the new boundary; see ADL-080.

See also the companion change in git.mchus.pro/reanimator/parser
(tagged v13.0.0): new top-level exports
(IsSupportedArchiveFilename/SupportedArchiveExtensions/
ParseInDefaultArchiveLocation/PrivacyScanEnabled) and pciids moved to
a public package, both needed to complete this migration.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-10-08 12:59:39 +03:00

86 lines
2.4 KiB
Go

package privacy
import (
"testing"
"git.mchus.pro/reanimator/parser/v13/models"
)
func TestIsSensitiveIP(t *testing.T) {
cases := []struct {
ip string
want bool
}{
{"45.32.10.7", true},
{"93.184.216.34", true},
{"2606:2800:220:1:248:1893:25c8:1946", true},
{"10.1.2.3", false},
{"172.16.5.5", false},
{"192.168.31.4", false},
{"127.0.0.1", false},
{"169.254.1.1", false},
{"0.0.0.0", false},
{"255.255.255.255", false},
{"224.0.0.1", false},
{"203.0.113.9", false},
{"198.51.100.1", false},
{"192.0.2.7", false},
{"8.8.8.8", false},
{"1.1.1.1", false},
{"100.64.0.1", false},
{"not-an-ip", false},
}
for _, c := range cases {
if got := isSensitiveIP(c.ip); got != c.want {
t.Errorf("isSensitiveIP(%q) = %v, want %v", c.ip, got, c.want)
}
}
}
func TestIsAllowlistedDomain(t *testing.T) {
yes := []string{"example.com", "host.example.local", "pool.ntp.org", "0.pool.ntp.org", "redhat.com", "a.b.jd.com"}
no := []string{"corp.acme.ru", "tcs.example-bank.com", "sigma.internal.io"}
for _, d := range yes {
if !isAllowlistedDomain(d) {
t.Errorf("%q should be allowlisted", d)
}
}
for _, d := range no {
if isAllowlistedDomain(d) {
t.Errorf("%q should not be allowlisted", d)
}
}
}
func TestRegistrableDomain(t *testing.T) {
cases := map[string]string{
"sn-x.mgmt.corp.example.local": "example.local",
"ntp01.acme.ru": "acme.ru",
"a.b.c.example.co.uk": "example.co.uk",
"10.20.30.40": "",
"localhost": "",
"com": "",
"*.wildcard.acme.ru": "acme.ru",
}
for in, want := range cases {
if got := registrableDomain(in); got != want {
t.Errorf("registrableDomain(%q) = %q, want %q", in, got, want)
}
}
}
func TestGuessCustomers_RanksStrongEvidence(t *testing.T) {
findings := []models.PrivacyFinding{
{Category: catResolv, Path: "resolv.conf", Line: 1, Match: "corp.acme.ru", Excerpt: "domain corp.acme.ru"},
{Category: catADLDAP, Path: "activedir.conf", Line: 3, Match: "corp.acme.ru", Excerpt: "racdomain=corp.acme.ru"},
{Category: catDomain, Path: "audit.log", Line: 9, Match: "noise.other.com", Excerpt: "x noise.other.com"},
}
got := guessCustomers(findings)
if len(got) == 0 || got[0].Domain != "acme.ru" {
t.Fatalf("got %+v, want acme.ru first", got)
}
if got[0].Confidence != "high" {
t.Errorf("confidence = %s, want high", got[0].Confidence)
}
}