Files
Mikhail ChusavitinandClaude Sonnet 5 475318fc2b refactor: extract parsers and Redfish replay/analysis to external module
logpile no longer carries its own archive/vendor parsers or Redfish
raw-payload replay/analysis engine. Both now live in
git.mchus.pro/reanimator/parser/v13 (already used by the sibling `core`
project), reached through parser.NewService().AnalyzeArchivePayload /
AnalyzeRedfishRawPayloads. logpile keeps live BMC/Redfish collection,
the DB, exporter, server and UI.

- Deleted internal/parser/ (interface, registry, archive extraction,
  all vendor packages), internal/collector/redfish_replay*.go (replay
  engine, confirmed near-identical to the module's redfish/ package),
  internal/ingest/ (pure duplicate of the module's Service),
  internal/models/ (repointed every import to the module's models
  package instead), and internal/rar5 (only used by the deleted
  archive extractor). Removed the now-unused third_party/pciids
  submodule.
- internal/collector/redfish.go: Collect() now calls
  parser.NewService().AnalyzeRedfishRawPayloads(...) at the one place
  it used to call the local ReplayRedfishFromRawPayloads (an existing
  "unified tunnel" between live collection and raw import). A
  deadcode-driven pass then removed ~150 doc-to-model conversion
  helpers in redfish.go that duplicated the module's redfish/ package
  and were already unreachable before this change; kept the small
  generic dedup/scoring helpers the live crawler still calls.
- internal/collector/redfishprofile/ stays whole: Collect() depends on
  it directly for acquisition-time tuning. Its analysis-only methods
  (ApplyAnalysisProfiles/PostAnalyze) are now dead but left in place
  rather than splitting the package's single Profile interface.
- pciids moved with the module (now a public package there); logpile's
  live collector and exporter import it from there instead of keeping
  a local copy.
- go.mod: new require on git.mchus.pro/reanimator/parser/v13 v13.0.0
  (plain module dependency, not a submodule like reanimator/chart,
  since this module is independently versioned and shared with core).
- bible-local docs rewritten for the new boundary; see ADL-080.

See also the companion change in git.mchus.pro/reanimator/parser
(tagged v13.0.0): new top-level exports
(IsSupportedArchiveFilename/SupportedArchiveExtensions/
ParseInDefaultArchiveLocation/PrivacyScanEnabled) and pciids moved to
a public package, both needed to complete this migration.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-10-08 12:59:39 +03:00

61 lines
1.7 KiB
Go

package collector
import "strings"
// dedupeRedfishPaths normalizes and removes duplicate Redfish resource paths.
func dedupeRedfishPaths(paths []string) []string {
out := make([]string, 0, len(paths))
seen := make(map[string]struct{}, len(paths))
for _, path := range paths {
path = normalizeRedfishPath(path)
if path == "" {
continue
}
if _, ok := seen[path]; ok {
continue
}
seen[path] = struct{}{}
out = append(out, path)
}
return out
}
// lastRedfishPathSegment returns the final path segment of a Redfish resource path.
func lastRedfishPathSegment(path string) string {
path = strings.Trim(strings.TrimSpace(path), "/")
if idx := strings.LastIndex(path, "/"); idx >= 0 {
return path[idx+1:]
}
return path
}
// redfishHostSystemScore ranks a candidate ComputerSystem document by how
// likely it is to be the actual host system, versus a management controller
// or other secondary system exposed at the same collection.
func redfishHostSystemScore(path string, doc map[string]interface{}, processorDocs []map[string]interface{}) int {
score := 0
if strings.EqualFold(lastRedfishPathSegment(path), "self") {
score += 25
}
if summary, ok := doc["ProcessorSummary"].(map[string]interface{}); ok && asInt(summary["Count"]) > 0 {
score += 80
}
if redfishLinkedPath(doc, "Bios") != "" {
score += 40
}
if _, ok := doc["Boot"].(map[string]interface{}); ok {
score += 20
}
if strings.TrimSpace(asString(doc["HostName"])) != "" {
score += 10
}
for _, processor := range processorDocs {
processorType := strings.TrimSpace(asString(processor["ProcessorType"]))
if processorType == "" || strings.EqualFold(processorType, "CPU") || strings.EqualFold(processorType, "General") {
score += 100
break
}
}
return score
}