redfish: optimize snapshot/plan-b crawl and add timing diagnostics

internal/collector/redfish_replay.go

@@ -1105,7 +1105,6 @@ func (r redfishSnapshotReader) probeDirectDiskBayChildren(drivesCollectionPath s
 
 func (r redfishSnapshotReader) collectNICs(chassisPaths []string) []models.NetworkAdapter {
 	var nics []models.NetworkAdapter
-	seen := make(map[string]struct{})
 	for _, chassisPath := range chassisPaths {
 		adapterDocs, err := r.getCollectionMembers(joinPath(chassisPath, "/NetworkAdapters"))
 		if err != nil {
@@ -1121,23 +1120,15 @@ func (r redfishSnapshotReader) collectNICs(chassisPaths []string) []models.Netwo
 				functionDocs := r.getLinkedPCIeFunctions(pcieDoc)
 				enrichNICFromPCIe(&nic, pcieDoc, functionDocs)
 			}
-			key := firstNonEmpty(nic.SerialNumber, nic.Slot+"|"+nic.Model)
-			if key == "" {
-				continue
-			}
-			if _, ok := seen[key]; ok {
-				continue
-			}
-			seen[key] = struct{}{}
 			nics = append(nics, nic)
 		}
 	}
-	return nics
+	return dedupeNetworkAdapters(nics)
 }
 
 func (r redfishSnapshotReader) collectPSUs(chassisPaths []string) []models.PSU {
 	var out []models.PSU
-	seen := make(map[string]struct{})
+	seen := make(map[string]int)
 	idx := 1
 	for _, chassisPath := range chassisPaths {
 		if memberDocs, err := r.getCollectionMembers(joinPath(chassisPath, "/PowerSubsystem/PowerSupplies")); err == nil && len(memberDocs) > 0 {
@@ -1213,7 +1204,6 @@ func (r redfishSnapshotReader) collectPCIeDevices(systemPaths, chassisPaths []st
 		collections = append(collections, joinPath(chassisPath, "/PCIeDevices"))
 	}
 	var out []models.PCIeDevice
-	seen := make(map[string]struct{})
 	for _, collectionPath := range collections {
 		memberDocs, err := r.getCollectionMembers(collectionPath)
 		if err != nil || len(memberDocs) == 0 {
@@ -1222,14 +1212,6 @@ func (r redfishSnapshotReader) collectPCIeDevices(systemPaths, chassisPaths []st
 		for _, doc := range memberDocs {
 			functionDocs := r.getLinkedPCIeFunctions(doc)
 			dev := parsePCIeDevice(doc, functionDocs)
-			key := pcieDeviceDedupKey(dev)
-			if key == "" {
-				continue
-			}
-			if _, ok := seen[key]; ok {
-				continue
-			}
-			seen[key] = struct{}{}
 			out = append(out, dev)
 		}
 	}
@@ -1240,18 +1222,10 @@ func (r redfishSnapshotReader) collectPCIeDevices(systemPaths, chassisPaths []st
 		}
 		for idx, fn := range functionDocs {
 			dev := parsePCIeFunction(fn, idx+1)
-			key := pcieDeviceDedupKey(dev)
-			if key == "" {
-				continue
-			}
-			if _, ok := seen[key]; ok {
-				continue
-			}
-			seen[key] = struct{}{}
 			out = append(out, dev)
 		}
 	}
-	return out
+	return dedupePCIeDevices(out)
 }
 
 func stringsTrimTrailingSlash(s string) string {