8.7 KiB
Issue implementation plan - 2026-10-26
Repository: https://git.mchus.pro/mchus/QuoteForge
Scope: issues #2-#7. Initial fixes were merged into main in
PR #8, with release notes in v3.50.
The follow-up adds completed acceptance checks and server migration recovery
required by the shared rules. Each issue has its own implementation/acceptance commit.
| Order | Issue | Implementation and acceptance | Status |
|---|---|---|---|
| 1 | #2 | Block foreign Host/Origin/Referer and cross-site browser requests in both routers; validate API body types; refuse saved-password reuse for a changed host/port/user. Middleware and real setup/runtime router tests reject attacks without changing saved credentials or user data. | Acceptance passed |
| 2 | #4 | Move LOT-bearing cart/rental events to delegated listeners and escaped data attributes; escape BOM and sync output; share HTML escaping; render toast as text. Malicious LOT regression checks and headless Chrome DOM checks pass. | Acceptance passed |
| 3 | #7 | Require a fresh verified archive outside rotation before reset, refuse unsynced/legacy states without explicit force, use transactional deletion, remove environment-triggered reset. Verified refusal, ZIP restore, backup failure, rollback and CLI startup after restore. | Acceptance passed |
| 4 | #5 | Persist TLS mode/CA in SQLite, expose setup controls, share policy across setup/sync/migration DSNs. Verified certificate trust, hostname checks, fallback policy, settings round-trip and live MariaDB 11.8 transport. | Acceptance passed |
| 5 | #3 | Keep each migration file in one session, execute verify headers before history insertion, propagate FK failures. Failed queries/checks restore the entire session. Verified snapshots, literal-aware SQL parsing, trigger preservation and crash recovery pass synthetic tests and production-dump rehearsal on MariaDB 11.8.3. | Acceptance passed |
| 6 | #6 | Require Go 1.27.3, update vulnerable dependencies, block release on pinned govulncheck. Tests, vet, security scan, cross-platform builds and release failure checks pass. | Acceptance passed |
Decisions
- HTTP forms remain supported on setup and multipart vendor import; JSON APIs reject non-JSON bodies. CLI clients may omit browser origin headers.
- CSP without inline scripts remains outside this patch; the issue lists it as optional.
- Forced reset still requires a verified backup.
QFS_RESET_LOCAL_DBis ignored, with a startup warning; only explicit CLI flags can initiate reset. - TLS defaults to
preferredfor existing-server compatibility, as requested in the issue. It permits plaintext fallback; useverify-fullfor authenticated encryption. The setup form explains this distinction. go 1.27.3enforces the minimum compiler, including withGOTOOLCHAIN=local. A redundanttoolchain go1.27.3is removed by Go tooling and is unnecessary.
Validation and handoff
The original implementation PR is merged. Current acceptance results are listed below. Govulncheck reports zero reachable vulnerabilities and one module-level advisory whose affected code is not called. Initial cross-platform builds and all Go/JavaScript checks pass; final verification also covers the recovery change. Production-dump rehearsal also passes on MariaDB 11.8.3 with the production collation. No production migration or new release is performed by this work.
Acceptance follow-up
Issue #2
go test ./cmd/qfs -run TestRequestBoundaryOnApplicationRouters -count=1
exercises the production setup and runtime route constructors with temporary
SQLite state. Foreign setup forms, opaque origins and rebinding hosts are
rejected, text/plain JSON receives 415, and both setup handlers reject saved
password reuse for a changed destination. Local reads still succeed. Saved
credentials, project/configuration counts and the pending queue remain unchanged.
The setup router construction was extracted without changing its routes so
this regression exercises the same middleware registration as startup.
Issue #4
node scripts/tests/html-security-browser.cjs passes in headless Chrome with
an isolated temporary profile. It executes the actual template rendering
functions in a browser DOM with controlled API responses. Both cart layouts,
rental, parsed BOM, toast, pending sync errors, error history and repair errors
preserve malicious strings as text. Real click/change/focus events preserve
LOT values through delegated handlers; no injected elements or payload execution
are observed. This is a rendering integration check, not a full application
navigation test. Set CHROME_BIN outside macOS to select a Chrome executable.
Issue #7
go test ./cmd/qfs ./internal/localdb -run TestReset -count=1 covers reset
safety and a subprocess executing the real main flag/startup path. With
rotating backups disabled, the environment switch does not reset pending work,
normal reset refuses it, and explicit forced reset creates a verified archive.
The test restores ZIP contents and reopens the database through normal startup:
connection settings and the pending queue survive. It deliberately selects
-migrate-status with an unavailable loopback database to stop startup before
HTTP/browser launch; no production database or user state is touched.
Issue #5
go test -tags integration ./internal/mariadb -run TestMariaDBTLSIntegration -count=1
starts its own disposable MariaDB 11.8 containers on random loopback ports, with
TLS enabled and disabled, and removes both afterward. The test verifies the
actual session cipher: preferred encrypts with a TLS server and falls back only
with a plaintext server; required and verification modes reject plaintext.
Correct trust succeeds, unrelated roots and wrong hostname fail. Certificates,
private keys and database storage are temporary; no saved user DSN is used.
The matching image must already exist locally (docker pull mariadb:11.8).
Setup policy, local settings and synthetic TLS tests also pass.
Issue #6
Go 1.27.3: go test ./..., go vet ./... and make security-check pass.
CGO-free builds produce macOS arm64 Mach-O and Windows amd64 PE executables
outside the repository. node scripts/tests/release-security.cjs substitutes a
failing Go scanner in an isolated directory and confirms all five release build
targets and scripts/release.sh stop before compilation or artifact creation.
The scanner reports zero reachable vulnerabilities and one uncalled module-level
advisory. No release is published by these acceptance checks.
Issue #3
The parser, mandatory server snapshots, restore-readiness checks, reverse step
recovery and explicit crash restore are implemented; see
server migration recovery decision.
go test -tags integration ./internal/models -run TestSQLMigrationSafetyMariaDB -count=1
passes on a disposable MariaDB 11.8: session variables and two verify checks,
semicolon literals, a later failed verify, a real FK errno 150 after successful
DDL, reverse recovery of prior files, interrupted-session refusal/restore/retry,
unsupported-schema refusal, active-client refusal and backup failure.
Restored schema, binary/NULL/empty/decimal/timestamp data and history are compared
to the original snapshot. Unit tests cover snapshot format/digests, symlink path
refusal and all embedded migration SQL syntax.
The supplied 2026-10-26_RFQ_LOG.sql dump (45 tables, 27 triggers) is loaded
read-only into a new disposable MariaDB 11.8.3 container with
utf8mb4_uca1400_ai_ci, matching the production version and collation.
TestProductionDumpMigrationMariaDB verifies a full snapshot restore, rebuilds
the pre-035 schema only in that clone, applies the real embedded migration 035,
forces a subsequent DDL/verify failure, verifies reverse recovery against the
complete pre-session snapshot, then applies 035 successfully and restores the
exact original dump state. Trigger bodies, definers and order are preserved;
triggers never fire during row loading. No production schema or dump file is changed.
Run this optional, destructive-to-its-own-container rehearsal with an existing
mariadb:11.8.3 image and QFS_TEST_PRODUCTION_DUMP=/outside/repository/dump.sql:
go test -tags integration ./internal/models -run TestProductionDumpMigrationMariaDB -count=1 -v
The environment variable supplies the source file only; no externally supplied DSN is accepted. The test owns and removes its container and temporary archives.