mchus/PriceForge
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Releases 2 Activity

Fix estimate data leaking into competitor/warehouse pricelists

Browse Source 
The else branch in CreateForSourceWithProgress was reading from
qt_lot_metadata (estimate snapshot) for any source when no items
were provided. This caused estimate prices, coefficients, manual
prices and meta_prices to be copied verbatim into competitor/warehouse
pricelists when called with empty item list.

Fix: else branch is now guarded to source=="estimate" only.
Any other source with no items returns an explicit error instead
of silently falling back to estimate data.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Mikhail Chusavitin
2026-03-13 08:09:47 +03:00
parent f48615e8a9
commit 592d77e30b
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/services/pricelist/service.go
View File

@@ -248,8 +248,8 @@ func (s *Service) CreateForSourceWithProgress(createdBy, source string, sourceIt
PricePeriodDays: srcItem.PricePeriodDays, PricePeriodDays: srcItem.PricePeriodDays,
}) })
} }
} else { } else if source == string(models.PricelistSourceEstimate) {
// Default snapshot source for estimate and backward compatibility. // Estimate snapshot: read current prices from qt_lot_metadata.
type LotMetadataWithCategory struct { type LotMetadataWithCategory struct {
models.LotMetadata models.LotMetadata
LotCategory string LotCategory string
@@ -315,6 +315,10 @@ func (s *Service) CreateForSourceWithProgress(createdBy, source string, sourceIt
MetaPrices: m.MetaPrices, MetaPrices: m.MetaPrices,
}) })
} }
} else {
// Non-estimate source with no items provided — refuse to fall back to estimate snapshot.
_ = s.repo.Delete(pricelist.ID)
return nil, fmt.Errorf("no items provided for source %q: explicit item list required", source)
} }
if len(items) == 0 { if len(items) == 0 {